Need io accressors for pxa168 otherwise need to touch sdhci.c for returning certain register values. ________________________________________ From: zhangfei gao [zhangfei.gao@xxxxxxxxx] Sent: Wednesday, November 24, 2010 9:31 PM To: Philip Rakity Cc: linux-mmc; Mark Brown Subject: Re: [PATCH] sdhci: Kconfig: MMC_SDHCI_PXA: CPU_MMP2 no need IO_ACCESSORS On Wed, Nov 24, 2010 at 4:30 PM, Philip Rakity <prakity@xxxxxxxxxxx> wrote: > Resend as plain text > > From 5ffe0546fb3d70dd97af178e474fbcdfa64ea4e8 Mon Sep 17 00:00:00 2001 > From: Philip Rakity <prakity@xxxxxxxxxxx> > Date: Wed, 24 Nov 2010 13:25:47 -0800 > Subject: [PATCH] sdhci: Kconfig: MMC_SDHCI_PXA: CPU_MMP2 no need IO_ACCESSORS > > read and write to MMP2 controller in sdhci-pxa does not use > IO_ACCESSORS. MMP2 hardware does not require special handling > for read and write. > > change Kconfig to not set this option. Speed Improvement. > > Signed-off-by: Philip Rakity <prakity@xxxxxxxxxxx> > --- > drivers/mmc/host/Kconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig > index f8fa9ef..f48532f 100644 > --- a/drivers/mmc/host/Kconfig > +++ b/drivers/mmc/host/Kconfig > @@ -170,7 +170,7 @@ config MMC_SDHCI_PXA > tristate "Marvell PXA168/PXA910/MMP2 SD Host Controller support" > depends on ARCH_PXA || ARCH_MMP > select MMC_SDHCI > - select MMC_SDHCI_IO_ACCESSORS > + select MMC_SDHCI_IO_ACCESSORS if !CPU_MMP2 > help > This selects the Marvell(R) PXA168/PXA910/MMP2 SD Host Controller. > If you have a PXA168/PXA910/MMP2 platform with SD Host Controller > -- > 1.6.0.4 > > Thanks, Could pxa168 can read HOST_VERSION from SDHCI_HOST_VERSION (BIT 0:7), if so, MMC_SDHCI_IO_ACCESSORS can be removed at all. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
