On Nov 22, 2010, at 8:59 PM, Haojian Zhuang wrote: > On Tue, Nov 23, 2010 at 11:22 AM, Philip Rakity <prakity@xxxxxxxxxxx> wrote: >> >> I implemented the first sdhci-pxa.c controller for the pxa168 over a year ago. Also fixed issues on Tavor. >> >> This approach is not sufficient to make Aspen nor Tavor work. >> >> There are a number of silicon issues that need to be addressed. >> >> >> >> > But we're formating patches for these silicons. I prefer to push > patches for Aspen/Tavor rather than restricting on CPU_MMP2 now. You can remove the CPU_MMP2 flag when that is done. > > This driver is used to share among Aspen/Tavor/MMP2. Since Mark and I did the pxa168 mmc code we would prefer that you leave the patches for us. Calling into the arch/ code for every platform does not seem the right way to go. It is probably simpler to factor out any common code and define platform specific modules for mmp2/aspen/tavor. Once you start working around the silicon issues calling into arch/ may not look like an approach that is easy to follow going forward. > > Thanks > Haojian -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
