I know it's too late, but... On Fri, Nov 19, 2010 at 09:53:33PM +0000, Chris Ball wrote: > On Fri, Nov 19, 2010 at 09:40:02PM +0000, Chris Ball wrote: > > I don't see why we should re-read ctrl here, since we've already written > > it back to the device at this point, and we don't use it anywhere below > > this line. > > Ah, I see why now; please ignore this. > > Here's a rebased version of the patch, with some more comments: > > From: Philip Rakity <prakity@xxxxxxxxxxx> > Date: Fri, 19 Nov 2010 16:48:39 -0500 > Subject: [PATCH] mmc: sdhci: 8-bit bus width changes > > We now: > * check for a v3 controller before setting 8-bit bus width > * offer a callback for platform code to switch to 8-bit mode, which > allows non-v3 controllers to support it What does the platform_-prefix of the callback indicate? > * introduce a quirk to specify that the board designers have indeed > brought out all the pins for 8-bit to the slot. This is not a quirk, this is platform_data, no? > We were previously relying only on whether the controller supported > 8-bit, which doesn't tell us anything about the pin configuration in > the board design. > > Signed-off-by: Philip Rakity <prakity@xxxxxxxxxxx> > Tested-by: Giuseppe Cavallaro <peppe.cavallaro@xxxxxx> > Signed-off-by: Chris Ball <cjb@xxxxxxxxxx> -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |
Attachment:
signature.asc
Description: Digital signature
