RE: [PATCH v1 1/3]Add erase timeout calculation routine for sdhci host

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi wolfram
> 
> Just a formal thing I noticed on a glimpse...
> 
You mean can directly set the TIMEOUT CONTROL register to be the maximum value?
And any comment about patch2 and patch3?

> > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index
> > 154cbf8..79fcca2 100644
> > --- a/drivers/mmc/host/sdhci.c
> > +++ b/drivers/mmc/host/sdhci.c
> > @@ -879,6 +879,48 @@ static void sdhci_finish_data(struct sdhci_host *host)
> >  		tasklet_schedule(&host->finish_tasklet);
> >  }
> >
> > +static void sdhci_set_erasetimeout(struct sdhci_host *host,
> > +		unsigned int erase_timeout)
> > +{
> > +	u64 current_timeout;
> > +	int count = 0xe;
> 
> I'd suggest a define with a speaking name instead of all the hardcoded 0xe.
Ok, will fix it in the next version submission.
Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux