Hi Ohad, On 11/10/2010 9:28 PM, Ohad Ben-Cohen wrote: > > Hi Giuseppe, > > On Wed, Nov 10, 2010 at 5:28 PM, Giuseppe CAVALLARO > <peppe.cavallaro@xxxxxx> wrote: > > HC driver will be able to use the pm_flags to > > undestand if the system can be woken-up by the driver. > > So the mmc_suspend_host hasn't to reset this field > > in the host structure. > > > > Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@xxxxxx> > > --- > > drivers/mmc/core/core.c | 1 - > > 1 files changed, 0 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c > > index 569e94d..6d2d6e4 100644 > > --- a/drivers/mmc/core/core.c > > +++ b/drivers/mmc/core/core.c > > @@ -1276,7 +1276,6 @@ int mmc_suspend_host(struct mmc_host *host) > > mmc_claim_host(host); > > mmc_detach_bus(host); > > mmc_release_host(host); > > - host->pm_flags = 0; > > This is elapsed because the card is removed at this point (e.g. SDIO > returned -ENOSYS). > > Why would you want to use flags, set by a function driver of an SDIO > card, that was just removed ? > The define MMC_PM_KEEP_POWER has been used to notify that a device driver (e.g. sdhci-pltfm) want to wakeup the system. It is set in the pm_flags. When the sdhci suspend is invoked, it can call the mmc_suspend_host without free the interrupt if MMC_PM_KEEP_POWER is set. Then the sdhci_set_wakeup programs the HC to be able to wake up the system. When the resume is invoked the pm_flags is used to avoid to request the irq. For this reason I removed the inst "host->pm_flags = 0;" from the mmc_suspend_host function. Maybe I could not remove it but add a check if the driver wants to wakeup the system and the MMC_PM_KEEP_POWER is set. What do you think? Thanks Regards, Peppe > > > > err = 0; > > } > > } > > -- > > 1.5.5.6 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > > the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
