We should rename sdhci-pxa.c to sdhci-mmp2.c and adjust Kconfig and the makefile accordingly since it is clear code is clearly processor dependent or The additional changes to support the pxa family of chips should be posted to the web. On Nov 10, 2010, at 6:08 PM, zhangfei gao wrote: > On Wed, Nov 10, 2010 at 4:58 PM, Philip Rakity <prakity@xxxxxxxxxxx> wrote: >> >> <snip> >> >>> +#define SD_CLOCK_AND_BURST_SIZE_SETUP 0x10A >> >> This offset is only for MMP2. On other pxa processors use a different offset. sdhci-pxa.c needs changing to support other pxa soc chips. > > The first stage is only considering MMP2, the next step wil consider > other processor, for example move private register to arch/ > >> >> The value only needs setting at initialization time or sdhci reset (RESET_ALL) > it is OK to put here, then no call back is needed. >> >> >> -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html