Re: [PATCH (1/5)] mmc: sdhci-pltfm calls the sdhci_alloc_host with pdev->dev

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

thanks for the work in general, just...

> -	if (pdev->dev.parent)
> -		host = sdhci_alloc_host(pdev->dev.parent, 0);
> -	else
> -		host = sdhci_alloc_host(&pdev->dev, 0);
> -
> +	host = sdhci_alloc_host(&pdev->dev, 0);
>  	if (IS_ERR(host)) {
>  		ret = PTR_ERR(host);
>  		goto err;

NACK. This part looks different in current mainline (and for a reason).
Removing the dev.parent-branch will break some PCI-based solutions.

I think you should first rebase the series to mmc-next and then ask for
review. It is too confusing for reviewers otherwise. At least, I will
stop here.

Kind regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux