On Mon, Nov 8, 2010 at 4:21 PM, Philip Rakity <prakity@xxxxxxxxxxx> wrote: > > On Nov 7, 2010, at 2:04 PM, Wolfram Sang wrote: > >> On Fri, Oct 08, 2010 at 12:31:34PM -0700, Philip Rakity wrote: >>> >>> 8 bit width is a new feature in the sd 3.0 spec. Add checks to >>> ensure HOST_CONTROL register set 8 bit mode only if sd 3.0 >>> >>> add quirk to indicate that board design supports 8 data lines. >>> The controller can support 8 data bits but the board design may >>> only bring out 4 data bits. >> >> This isn't a quirk, this is platform_data, no? > > Never sure of the difference between a quirk and platform data. > example: Broken card detect is a quirk but maybe some slots on the board work and some do not In my case, one slot uses the 8-bit but another is 4-bit so host quirk is not acceptable. I prefer the platform data also. Thank you, Kyungmin Park > >> >> Without looking deeply into it, I think we need to use the callback you >> introduced in the other patch? >> > > It is needed in my experience because of how board design is done. The controller can support 8 bits > but the board may not have DAT4-DAT7 connected. > >> Regards, >> >> Wolfram >> >> PS: Sorry if there already was a discussion I might have missed. The bus width >> thingie became a bit scattered, so I lost track... >> >> -- >> Pengutronix e.K. | Wolfram Sang | >> Industrial Linux Solutions | http://www.pengutronix.de/ | > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
