Re: commit 'mmc: sdhci: add MMC_CAP_8_BIT_DATA in the host capabilities' breaks ricoh mmc device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

I got the same problem.

diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 782c0ee..a0991ad 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -1849,7 +1849,7 @@ int sdhci_add_host(struct sdhci_host *host)
        mmc->caps |= MMC_CAP_SDIO_IRQ;

        if (!(host->quirks & SDHCI_QUIRK_FORCE_1_BIT_DATA))
-               mmc->caps |= MMC_CAP_4_BIT_DATA | MMC_CAP_8_BIT_DATA;
+               mmc->caps |= MMC_CAP_4_BIT_DATA;

        if (caps & SDHCI_CAN_DO_HISPD)
                mmc->caps |= MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED;

In case of MMC, host->caps & MMC_CAP_8_BIT_DATA is always true. so
can't use the MMC_CAP_4_BIT_DATA.

       /*
         * Activate wide bus and DDR (if supported).
         */
        if ((card->csd.mmca_vsn >= CSD_SPEC_VER_4) &&
            (host->caps & (MMC_CAP_4_BIT_DATA | MMC_CAP_8_BIT_DATA))) {
                unsigned ext_csd_bit, bus_width;

                if (host->caps & MMC_CAP_8_BIT_DATA) {
                        if (ddr)
                                ext_csd_bit = EXT_CSD_DDR_BUS_WIDTH_8;
                        else
                                ext_csd_bit = EXT_CSD_BUS_WIDTH_8;
                        bus_width = MMC_BUS_WIDTH_8;
                } else {
                        if (ddr)
                                ext_csd_bit = EXT_CSD_DDR_BUS_WIDTH_4;
                        else
                                ext_csd_bit = EXT_CSD_BUS_WIDTH_4;
                        bus_width = MMC_BUS_WIDTH_4;
                }

Thank you,
Kyungmin Park

On Wed, Nov 3, 2010 at 3:24 PM, Wolfram Sang <w.sang@xxxxxxxxxxxxxx> wrote:
> On Wed, Nov 03, 2010 at 06:57:35AM +0100, Wolfram Sang wrote:
>> On Sat, Oct 30, 2010 at 05:53:46AM +0200, Maxim Levitsky wrote:
>> > Hi,
>> >
>> > I just bisected and reverted this commit.
>>
>> Commit-ID would have been useful, too: b08caed8659ab27199db51c63a35c5ee067fc7ef
>> Also, adding the author to cc, done now.
>
> Sorry, just saw that the threading got somehow broken and the thread was
> continued. Sorry for the noise!
>
> --
> Pengutronix e.K.                           | Wolfram Sang                |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
>
> iEYEARECAAYFAkzRAB8ACgkQD27XaX1/VRtSHACgvSytzl8BXzNFuM31HDWryl/4
> HPoAnRGReSnUgTbjOzGYOepJbcPhprGa
> =oMKq
> -----END PGP SIGNATURE-----
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux