On Thu, Oct 7, 2010 at 9:52 AM, Madhusudhan <madhu.cr@xxxxxx> wrote: > >> -----Original Message----- >> From: Steve Sakoman [mailto:sakoman@xxxxxxxxx] >> Sent: Thursday, October 07, 2010 8:57 AM >> To: Mike Rapoport >> Cc: Madhusudhan Chikkature; David Vrabel; Chris Ball; linux- >> mmc@xxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx; Adrian Hunter >> Subject: Re: [PATCH 0/2] mmc: omap_hsmmc: support SDIO cards (#2) >> >> On Thu, Oct 7, 2010 at 12:15 AM, Mike Rapoport <mike@xxxxxxxxxxxxxx> >> wrote: >> > Hi Madhu, >> > >> > Madhusudhan Chikkature wrote: >> >> >> >> <snip> >> >> >> >>> You are correct! The version of the patch in the repo indeed has >> >>> 'out' in the wrong place and generates a compile error. >> >>> >> >>> Could you post the patch you are using and I will try to reproduce >> >>> what you are seeing on my hardware? Best we all work from exactly the >> >>> same patch! >> >>> >> >>> Steve >> >>> >> >> >> >> Yes. I think that check breaking the compilation is not needed. How >> about >> >> the >> >> below version? It just removes that check. >> >> >> >> This version should apply fine on the latest kernel. I did a sanity >> test >> >> of >> >> MMC/SD cards on OMAP4 SDP. >> >> >> >> Steve or Mike can check if SDIO interrupts are working. >> > >> > With you patch I get the same: >> > >> > libertas_sdio: Libertas SDIO driver >> > libertas_sdio: Copyright Pierre Ossman >> > libertas: command 0x0003 timed out >> > libertas: Timeout submitting command 0x0003 >> > libertas: PREP_CMD: command 0x0003 failed: -110 >> > libertas_sdio: probe of mmc1:0001:1 failed with error -110 >> >> I can confirm exactly the same behavior on my hardware with this >> version of the patch. >> > > Steve, > > Okay. Did the version you had in your tree worked? I just want to check if I > messed up something in my patch. No, it didn't. Operator error -- I was "testing" a version without the patch applied :-) When applied it acts the same as your version. Steve -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html