Jeongbae Seo wrote:
>
> From: Hyuk Lee <hyuk1.lee@xxxxxxxxxxx>
>
> This patch adds support HSMMC for S5PV310 and S5PC210 and
> setup for HSMMC host controller and also related GPIO.
> At most 4 channel can be used at the same time.
> A user can configure SDHCI data bus as 8bit or 4bit.
>
> Signed-off-by: Hyuk Lee <hyuk1.lee@xxxxxxxxxxx>
> Signed-off-by: Jeongbae Seo <jeongbae.seo@xxxxxxxxxxx>
> ---
(snip)
> + /* Set all the necessary GPK0[0:1] pins to special-function 2 */
> + for (gpio = S5PV310_GPK0(0); gpio < S5PV310_GPK0(2); gpio++) {
> + s3c_gpio_cfgpin(gpio, S3C_GPIO_SFN(2));
> + s3c_gpio_setpull(gpio, S3C_GPIO_PULL_NONE);
Hi
Maybe as you know, above lines can be changed like below.
s3c_gpio_cfgrange_nopull(S5PV310_GPK0(0), 2, S3C_GPIO_SFN(2));
Of course regarding gpio update patches are not pulled in my for-next yet,
because under reviewing in ML now.
But I think, you can do it against dev/gpio-update.
Anyway could you please make additional patch for it?
It would be nice if you could do it :-)
Others ok to me...but I will sort out regarding sdhci gpio configuration in
future time.
(snip)
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
