On Thu, Sep 30, 2010 at 10:31:58AM +0200, Lothar WaÃmann wrote: > > The custom init call may need more data to perform its job, so we pass > > it a pointer to pdata, too. Also, always use the platform_id specific > > data even if platform_data is present. Doing that, platform_data can > > additionally be parsed by init() for board-specific information (via > > sdhci->mmc->parent). > > > Why not a pointer to the platform_device itself? Then the callback > function would have even more information (e.g. platform_device ID) > and could easily get at the platform_data too. dev->platform_data may not be there. There are two ways to pass the "platform data" to the sdhci-pltfm driver: a) via dev->platform_data b) via platform_device_id->driver_data Technically, we can do something like this in the probe(): if (!pdev->dev.platform_data) pdev->dev.platform_data = platform_device_id->driver_data; pdata->init(dev); Note, in this case we must also NULLify platform_data it at remove(), as platform_device_release() will try to free statically allocated memory. Thanks, -- Anton Vorontsov email: cbouatmailru@xxxxxxxxx irc://irc.freenode.net/bd2 -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html