On Tue, Sep 28, 2010 at 02:36:45PM +0200, Wolfram Sang wrote: > Put everything which can be shared between the OF and platform version > of this driver into a local .h-file. > > Signed-off-by: Wolfram Sang <w.sang@xxxxxxxxxxxxxx> > --- > > Note: Anton suggested to move the function out of the .h-file into a seperate > .c-file. I tried this and it looked overly complicated to me; we ended up with > a tiny .c _and_ .h file with no gain but a lot of complication added IMHO. > So, while not being perfect, I hope we can live with this version. I'd still like to see it as a C file. [...] > +static void esdhc_set_clock(struct sdhci_host *host, unsigned int clock) But if you do this in the .h file, you have to make it 'inline', otherwise gcc might emit 'defined but not used' warning. Thanks, -- Anton Vorontsov email: cbouatmailru@xxxxxxxxx irc://irc.freenode.net/bd2 -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
