zhangfei gao wrote:
> On Mon, Sep 20, 2010 at 10:34 AM, David Vrabel <david.vrabel@xxxxxxx> wrote:
>> zhangfei gao wrote:
>>> index 5db49b1..9114c87 100644
>>> --- a/drivers/mmc/core/core.c
>>> +++ b/drivers/mmc/core/core.c
>>> @@ -910,9 +910,9 @@ static void mmc_power_up(struct mmc_host *host)
>>> if (host->f_min > 400000) {
>>> pr_warning("%s: Minimum clock frequency too high for "
>>> "identification mode\n", mmc_hostname(host));
>>> - host->ios.clock = host->f_min;
>>> - } else
>>> host->ios.clock = 400000;
>>> + } else
>>> + host->ios.clock = host->f_min;
>> NAK.
>>
>> The code is already correctly requesting 400 kHz (unless the controller
>> can't go that slow).
>
> Original code
> if (host->f_min > 400000) {
> pr_warning("%s: Minimum clock frequency too high for "
> "identification mode\n", mmc_hostname(host));
> host->ios.clock = host->f_min;
> } else
> host->ios.clock = 400000;
>
> With this code, the init clock is would be at lease 400 kHz, and no
> matter how bigger the host->f_min it is, is this really correct?
It's not clear what you're saying or why you think the original code is
wrong. Consider a host controller that reports a minimum frequency of 1
Hz. Obviously we wouldn't want to do the card identification at this
clock rate, yes?
David
--
David Vrabel, Senior Software Engineer, Drivers
CSR, Churchill House, Cambridge Business Park, Tel: +44 (0)1223 692562
Cowley Road, Cambridge, CB4 0WZ http://www.csr.com/
Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
