On Sun, Sep 26, 2010 at 8:39 PM, Eric Miao <eric.y.miao@xxxxxxxxx> wrote: > On Sun, Sep 26, 2010 at 6:56 PM, zhangfei gao <zhangfei.gao@xxxxxxxxx> wrote: >> >> --- >> arch/arm/plat-pxa/include/plat/sdhci.h | 32 +++++++ >> drivers/mmc/host/Kconfig | 11 +++ >> drivers/mmc/host/Makefile | 1 + >> drivers/mmc/host/sdhci-pxa.c | 143 ++++++++++++++++++++++++++++++++ > > I prefer we rename it to something like sdhci-mmp.c and the 'pxa' in the source > code to 'mmp' to cause less confusion with pxamci.c? > Maybe sdhci-pxa.c is better. pxamci.c isn't compatible with sdhci, so it won't make people confusion. >> + >> +#endif /* __PLAT_PXA_SDHCI_H */ >> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig >> index 6f12d5d..9510976 100644 >> --- a/drivers/mmc/host/Kconfig >> +++ b/drivers/mmc/host/Kconfig >> @@ -158,6 +158,17 @@ config MMC_SDHCI_S3C >> >> If unsure, say N. >> >> +config MMC_SDHCI_PXA >> + tristate "Marvell PXA168/PXA910/MMP2 SD Host Controller support" >> + depends on ARCH_PXA || ARCH_MMP > > Only on ARCH_MMP or is this also used in PXA950+? > This SD controller IP is also used in PXA955. PXA955 (MG1) belongs to ARCH_PXA. So MMC_SDHCI_PXA should be depend on ARCH_PXA or ARCH_MMP. Thanks Haojian -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html