Hi Wolfram: I have the following a few common comments about these patches. * About the share between i.MX and PPC eSDHC. Why configure a few parts be shared between the i.MX eSDHC and PPC eSDHC? Can they be separated into two independent systems? It would bring the conveniences to maintain stuff in the future if we separate them. And there is already one set of eSDHC driver for all the i.MX SOCs. As we know that i.MX and PPC are the disparate SOC families. * About the driver name of i.MX eSDHC driver, I think that use the imx to identify it is better than esdhc. As I know that the eSDHC name wouldn't be used anymore in next generation SOCs of i.MX family. So the name of imx would be much clear and exact. Best Regards, Richard Zhu Freescale Semiconductor Tel: +86-021-28937189 Email:Hong-Xing.Zhu@xxxxxxxxxxxxx -----Original Message----- From: Wolfram Sang [mailto:w.sang@xxxxxxxxxxxxxx] Sent: Tuesday, 21 September, 2010 20:30 To: linux-mmc@xxxxxxxxxxxxxxx Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Anton Vorontsov; Zhu Richard-R65037; Wolfram Sang Subject: [PATCH 0/4] Adding support for esdhc on mx35/51 Hi, this series adds basic support for the esdhc-controller found on mx35/51-cpus. It first extends the sdhci-pltfm-driver to have a runtime-structure for data (1/4), does a bit of cleanup (2/4), extracts a few parts which can be shared with the OF-version (3/4) and finally adds the driver (4/4). Note that the support is basic at the moment. Still to be done are: * ADMA support (Richard Zhu mentioned it has issues and knows the details) * 8-Bit bus width (needs more research; it breaks some cards for me :( ) * voltage switching using a regulator (I don't have such hardware, hopefully Richard can pick this up) * write_protect using a GPIO (we need to retrieve board-specific data for that; an RFC follows after this series) Platform resources could be posted after write_protect issue has been sorted out. Please review and/or give comments. Please let me also know if you intend to work on a missing bit. Thanks, Wolfram === Wolfram Sang (4): mmc: sdhci-pltfm: Add structure for host-specific data mmc: sdhci-pltfm: move .h-file into apropriate subdir mmc: sdhci-of-esdhc: factor out common stuff mmc: sdhci-pltfm: add pltfm-driver for imx35/51 drivers/mmc/host/Kconfig | 9 +++ drivers/mmc/host/Makefile | 1 + drivers/mmc/host/sdhci-cns3xxx.c | 2 +- drivers/mmc/host/sdhci-esdhc.c | 141 +++++++++++++++++++++++++++++++++++++ drivers/mmc/host/sdhci-esdhc.h | 81 +++++++++++++++++++++ drivers/mmc/host/sdhci-of-esdhc.c | 70 ++---------------- drivers/mmc/host/sdhci-pltfm.c | 12 +++- drivers/mmc/host/sdhci-pltfm.h | 8 ++- include/linux/mmc/sdhci-pltfm.h | 35 +++++++++ include/linux/sdhci-pltfm.h | 35 --------- 10 files changed, 292 insertions(+), 102 deletions(-) create mode 100644 drivers/mmc/host/sdhci-esdhc.c create mode 100644 drivers/mmc/host/sdhci-esdhc.h create mode 100644 include/linux/mmc/sdhci-pltfm.h delete mode 100644 include/linux/sdhci-pltfm.h -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
