Re: [PATCH] sdhci: print out controller name for register debug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Wolfram,

On Thu, Sep 23, 2010 at 10:39:46AM +0200, Wolfram Sang wrote:
> Uh, that was fast.

Sorry, you're right, was fast.  I'm okay with improving patches after
they enter mmc-next, but I'll leave more time for comments on patches
in future before merging.

> I would have preferred to switch the whole printout to dev_dbg?

That's a much bigger change, though -- you'd be making sdhci_dumpregs()
a no-op unless CONFIG_MMC_DEBUG is defined, right?  That's a change in
semantics, since it's intentionally called from many non-debug error
paths right now.

Thanks,

-- 
Chris Ball   <cjb@xxxxxxxxxx>   <http://printf.net/>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux