Hi, On Mon, Sep 20, 2010 at 11:16:18PM -0400, zhangfei gao wrote: > We have considered using the same driver with dove once saeed push the > driver, but at last we decide to use seperate driver to easy > maintaince and further extension. > > There are different IP developed by different group between Dove and > pxa168/pxa910/mmp2, and would be more and more different. > The pxa serious ip is follow sdh spec 3.0, and support sd 3.0 and emmc > 4.4, which need ddr50 and 1.8v requirement, the limitation is adma > still has some issue and in fixing. > Still some private register with differnt address, such as power > control, clock timming tunning and etc. > > The dove ip is follow sdh spec 2.0, and it has own limitation, such as > 1.8v may not be supported. > > In a word, they are differnt ip, and it is reasonable to use seprate driver. Okay. If we're going to have two different MV_SDHCI drivers, please coordinate to have different Kconfig entries for the Dove/MMP and MMP2 drivers that correctly identify which SoCs are supported by each, and resend. Neither driver should be called CONFIG_MV_SDHCI, since there will be no one driver for all MV_SDHCIs. Thanks, - Chris. -- Chris Ball <cjb@xxxxxxxxxx> <http://printf.net/> One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html