Re: [PATCH 2/2] sdhci: disable MMC_CAP_NEEDS_POLL in nonremovable case

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 08, 2010 at 10:27:14AM +0900, Jaehoon Chung wrote:
> Matt Fleming wrote:
> > On Thu, Sep 02, 2010 at 05:51:45PM +0900, Jaehoon Chung wrote:
> >> Matt Fleming wrote:
> >>> From: Jaehoon Chung <jh80.chung@xxxxxxxxxxx>
> >>>
> >>> If controller use SDHCI_QUIRK_BROKEN_CARD_DETECTION quirk,
> >>> controller need always polling detect
> >>>
> >>> In this case, always generated interrupt.Because controller checked card status.
> >>> I think that is not efficiently.
> >>>
> >>> But if card is nonremovable, we need not always polling.
> >>> So i added the check-point which is nonremovable or not
> >>>
> >>>  Signed-off-by: Jaehoon Chung <jh80.chung@xxxxxxxxxxx>
> >>> ---
> >>>  drivers/mmc/host/sdhci.c |    5 +++--
> >>>  1 files changed, 3 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> >>> index f6be963..3111859 100644
> >>> --- a/drivers/mmc/host/sdhci.c
> >>> +++ b/drivers/mmc/host/sdhci.c
> >>> @@ -1827,8 +1827,9 @@ int sdhci_add_host(struct sdhci_host *host)
> >>>  	if (caps & SDHCI_CAN_DO_HISPD)
> >>>  		mmc->caps |= MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED;
> >>>  
> >>> -	if (host->quirks & SDHCI_QUIRK_BROKEN_CARD_DETECTION)
> >>> -		mmc->caps |= MMC_CAP_NEEDS_POLL;
> >>> +	if ((host->quirks & SDHCI_QUIRK_BROKEN_CARD_DETECTION) &&
> >>> +		!mmc_card_is_removable(mmc))
> >>> +			mmc->caps |= MMC_CAP_NEEDS_POLL;
> >>>  
> >>>  	mmc->ocr_avail = 0;
> >>>  	if (caps & SDHCI_CAN_VDD_330)
> >>>   
> >> !mmc_card_is_removable(mmc)  is right?
> >> i think that is mmc_card_is_removable..
> >> because when card is removable, host controller needs polling.
> >>
> >> +	if ((host->quirks & SDHCI_QUIRK_BROKEN_CARD_DETECTION) &&
> >> +		*mmc_card_is_removable(mmc))*
> >> +			mmc->caps |= MMC_CAP_NEEDS_POLL;
> >>
> > 
> > Sorry, I messed up the logic here. You're completely correct.
> > 
> > With this change and patch 2/2 does your controller function
> > correctly?
> > 
> yes. i changed and applied this patch, then i tested in my controller.
> it's working well.

Chris, are you OK to pick this up (including Jaehoon's change)? Or
would you prefer me to resubmit?
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux