Hi Ohad, On Tue, Sep 07, 2010 at 02:29:08PM +0300, Ohad Ben-Cohen wrote: > @@ -152,6 +173,11 @@ static int sdio_bus_remove(struct device *dev) > sdio_release_host(func); > } > > + pm_runtime_put_noidle(dev); > + > + /* Undo the runtime PM settings in sdio_bus_probe() */ > + pm_runtime_put_noidle(dev); > + > return 0; > } > Nit: This makes sense in context, but stands out as a possible paste accident on first sight. :) I think it's worth adding a comment to the first call; something like: > + /* First, undo the increment made directly above */ > + pm_runtime_put_noidle(dev); > + > + /* Then undo the runtime PM settings in sdio_bus_probe() */ > + pm_runtime_put_noidle(dev); > + Thanks, -- Chris Ball <cjb@xxxxxxxxxx> <http://printf.net/> One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
