On Tue, Sep 14, 2010 at 02:40:57PM +0100, Alan Cox wrote: > On Tue, 14 Sep 2010 16:21:29 +0200 > Wolfram Sang <w.sang@xxxxxxxxxxxxxx> wrote: > > > On Mon, Sep 13, 2010 at 06:39:41PM +0100, Alan Cox wrote: > > > Coding style fixes > > > > > > Signed-off-by: Alan Cox <alan@xxxxxxxxxxxxxxx> > > > > Shouldn't this be folded into the patch which initially creates > > sdhci-intel-mid.c? > > The work was done later and the signoffs are not the same. In the ideal > world - yes of course. I can redo them this way if you want but it'll > probably be about a month. I would indeed prefer to first have minimal changes to the mmc/sdhci-core and then have the final version of sdhci-intel-mid.c put on top of that (also applies to patch 4/7). Less error prone and easier to review. Yet, I am not the one who is picking up the patches. (BTW can't you just combine SoB if you fold patches?) -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |
Attachment:
signature.asc
Description: Digital signature
