2010/9/9 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>:
> On Sun, 5 Sep 2010 11:05:38 +0200
> Linus Walleij <linus.walleij@xxxxxxxxxxxxxx> wrote:
>> + if (host->vcc) {
>> + int ret;
>> +
>> + if (power_mode == MMC_POWER_UP)
>> + ret = mmc_regulator_set_ocr(host->mmc, host->vcc, vdd);
>> + else if (power_mode == MMC_POWER_OFF)
>> + ret = mmc_regulator_set_ocr(host->mmc, host->vcc, 0);
>> + }
>
> There's no point in copying the return value into a local then ignoring
> it. mmc_regulator_set_ocr() can return a negative errno so we should
> test for that, clean up and propagate the error.
OK I'll fix.
> The same comments apply to mmci_set_ios().
OK.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
