Wolfgang Mües wrote: > Hi, > > Am 29.08.2010 23:39, schrieb Ryan Mallon: >> I see this is already applied, but why all the type trickery here? Why >> not just: >> >> memcpy(dmabuf, sgbuffer, amount); >> dmabuf += amount / sizeof(dmabuf); > > Because this is wrong? > > Maybe you mean sizeof(*dmabuf)? Sorry, yes. > The exact style of the bug fix is not important, it's important that > it's fixed. I disagree, it's also important that it is fixed in a clear, understandable way. I found the fix confusing, especially since there are casts to both signed and unsigned char. ~Ryan -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
