On Sat, Aug 28, 2010 at 04:48:58PM +0200, Linus Walleij wrote: > 2010/8/27 Chris Ball <cjb@xxxxxxxxxx>: > > Looks like this patch got dropped because of the missing modifications > > to arch/arm/mach-omap2/mmc-twl4030.c. Are we still interested in the > > patch otherwise, and can anyone help with that? > Actually just before the summer I submitted something not quite similar: > I moved all regulator handling *out* of the MMC core because I didn't > trust the way reference counting was being handled. This seems like the wrong approach; if there's a problem it'd seem much better to fix the core code that everything is sharing rather than factor it out - the location of the code is orthogonal to its helpfulness. > There is something very disturbing about this code from > regulator/core/core.c mmc_regulator_set_ocr(): The MMC code in the core was last time I looked explicitly reliant on the regulators not being shared - it wants the regulators to be grebbed with regulator_get_exclusive() which guarantees that. When the code was added there was a strong insistance that shared supplies could not be used with MMC so this was fine. > So it looks to me like it is possible for one slot to enable the > regulator and race with another slot which disables it at the > same time and end up with the regulator disabled :-( It's not really a race, it's just a simple inability to cope with something else sharing the same regulator - at the minute it'll do things like turn off the regulator when one port is done even if the other port still needs it. > My solution would still be to move the enable/disable out > of the core, so I need to follow up on that. The code needs to be changed so that the port remembers internally if it itself needs the regulator enabled or disabled rather than inspecting the current hardware state since that may differ as a result of being forced by the system or the activity of other ports. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
