Re: [PATCH] MMC: fix the use of kunmap_atomic() in tmio_mmc.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andrew

On Thu, 26 Aug 2010, Andrew Morton wrote:

> On Sat, 14 Aug 2010 22:29:40 +0200 (CEST)
> Guennadi Liakhovetski <g.liakhovetski@xxxxxx> wrote:
> 
> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>
> 
> No changelog :(

Sorry, I thought this was one of the cases, where the subject says it all.

> - what was wrong with the old code?
> 
> - how did the patch fix it?

How about:

kunmap_atomic() takes the cookie, returned by the kmap_atomic() as its 
argument and not the page address, used as an argument to kmap_atomic(). 
This patch fixes the compile error:

In file included from /opt/src/linux-2.6/drivers/mmc/host/tmio_mmc.c:37:
/opt/src/linux-2.6/drivers/mmc/host/tmio_mmc.h: In function 'tmio_mmc_kunmap_atomic':
/opt/src/linux-2.6/drivers/mmc/host/tmio_mmc.h:192: error: negative width in bit-field '<anonymous>'

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux