On Wed, 25 Aug 2010 15:05:02 -0700
Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> Actually I don't know what happened with this. I merged it on July 8
> and appear to have dropped it on July 27, but I can't find its
> removed-from-mm email so I don't know why I dropped it. Weird.
Oh, interesting.
> Oh well, I merged it again. Is 2.6.37 an appropriate merge schedule?
I'll defer that to Goda and Paul but that seems reasonable to me.
> > Yusuke, have I interpreted your changelog correctly? Also note that
> > your patch should remove the comment above the conditional that says,
> > "Hardware cannot perform 1 and 2 byte requests in 4 bit mode".
>
> this?
>
> --- a/drivers/mmc/host/tmio_mmc.c~tmio_mmc-revise-a-limit-of-the-data-size-fix
> +++ a/drivers/mmc/host/tmio_mmc.c
> @@ -660,7 +660,6 @@ static int tmio_mmc_start_data(struct tm
> pr_debug("setup data transfer: blocksize %08x nr_blocks %d\n",
> data->blksz, data->blocks);
>
> - /* Hardware cannot perform 1 and 2 byte requests in 4 bit mode */
> if (data->blksz < 2 && host->mmc->ios.bus_width == MMC_BUS_WIDTH_4) {
> pr_err("%s: %d byte block unsupported in 4 bit mode\n",
> mmc_hostname(host->mmc), data->blksz);
> _
>
I was thinking more like changing the comment to say "Hardware cannot
perform 1 byte requests in 4 bit mode" but that's evident from the
check. So sure, removing it seems sane.
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
