On Thu, 19 Aug 2010, David Vrabel wrote:
> Add a driver for USB SD Host Controller devices. These devices are
> Cypress Astoria chips with firmware compliant with issue 2 of CSR's USHC
> specification.
>
> Signed-off-by: David Vrabel <david.vrabel@xxxxxxx>
Looks good from a quick glance. Some nits below.
> +config MMC_USHC
> + tristate "USB SD Host Controller (USHC) support"
> + depends on USB
> + help
> + This selects support for USB SD Host Controllers based on
> + the Cypress Astoria chip with firmware compliant with CSR's
> + USB SD Host Controller specification (CS-118793-SP).
> +
> + CSR boards with this device include: USB<>SDIO (M1985v2),
> + and Ultrasira.
> +
> + Note: Version 2 devices only support SDIO cards/devices.
Do you mean that only the devices with version 2 do support SDIO, or
that devices with version 2 support SDIO only?
> + /* The Astoria's data FIFOs don't work with clock speeds < 5MHz so
> + limit commands with data to 6MHz or more. */
> + if (req->data && ushc->clock_freq < 6000000) {
> + ret = -EINVAL;
> + goto out;
> + }
[...]
> + mmc->f_min = 0;
> + mmc->f_max = 50000000;
Why are you setting mmc->f_min to zero? I understand that the 6000000
limit is only for commands with data, but a limit of 0 is rather ...
unusual.
Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
