On Mon, 16 Aug 2010 07:17:21 +0200 Uwe Kleine-König wrote: > Hello, > > On Fri, Aug 13, 2010 at 08:33:40PM +0900, Kukjin Kim wrote: > > Kukjin Kim wrote: > > > > > > Hi, > > > > > > Following is build error when selected MMC without PM. > > > > > > drivers/built-in.o: In function `mmc_alloc_host': > > > drivers/mmc/core/host.c:108: undefined reference to `mmc_pm_notify' > > > make[1]: *** [.tmp_vmlinux1] Error 1 > > > make: *** [sub-make] Error 2 > > > > > > That is added from Maxim's ' mmc: fix all hangs related to mmc/sd card > > > insert/removal during suspend/resume ' > > > (commit ID: 4c2ef25fe0b847d2ae818f74758ddb0be1c27d8e) > > > > > > Below is temporary patch for avoiding build error. > > > But I'm not sure about this... :-( > > > > > > --- > > > > > > diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c > > > index 0efe631..d80cfdc 100644 > > > --- a/drivers/mmc/core/host.c > > > +++ b/drivers/mmc/core/host.c > > > @@ -86,7 +86,9 @@ struct mmc_host *mmc_alloc_host(int extra, struct device > > > *dev) > > > init_waitqueue_head(&host->wq); > > > INIT_DELAYED_WORK(&host->detect, mmc_rescan); > > > INIT_DELAYED_WORK_DEFERRABLE(&host->disable, > > > mmc_host_deeper_disable); > > > +#ifdef CONFIG_PM > > > host->pm_notify.notifier_call = mmc_pm_notify; > > > +#endif > > > > > > /* > > > * By default, hosts do not support SGIO or large requests. > > > > > > --- > > > > Kindly ignore this stuff because I found Uwe's same patch just now ;-) > > Sorry for bothering. > For those who care: > > http://mid.gmane.org/1281691473-15481-1-git-send-email-u.kleine-koenig@xxxxxxxxxxxxxx > > Kgene, do you care to ack this change as it may prod akpm in taking the > fix a bit earlier? or this one from earlier: http://lkml.org/lkml/2010/8/12/207 --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
