Re: [PATCH v4 3/8] wireless: wl1271: add platform driver to get board data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, Aug 11, 2010 at 08:52:54PM +0200, ext DebBarma, Tarun Kanti wrote:
True; however if we go by that argument than we can also assume pdata is valid, so that we would not need the below check.

of course not. You can have devices that just play well with default values or devices where you don't need the flexibility of platform data. That's why we check.

platform_device pointers on the other hand, are guaranteed to be always true, if it isn't then you should oops, you deserve to oops because something is really really wrong.

Still, I would go ahead and find out if there is any scenario where pdev can go wrong during device registration. Thanks.

if that scenario ever happens, it's either a bug on your implementation or driver-core. In both cases you deserve to oops so we catch such problems at early stages.

--
balbi

DefectiveByDesign.org
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux