The patch titled mmc: use regulator framework correctly has been added to the -mm tree. Its filename is mmc-use-regulator-framework-correctly.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: mmc: use regulator framework correctly From: Adrian Hunter <adrian.hunter@xxxxxxxxx> Issues with the regulator framework no longer exist, so regulator_enable() / regulator_disable() should be used correctly. Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx> Cc: Liam Girdwood <lrg@xxxxxxxxxxxxxxx> Cc: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> Cc: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx> Cc: <linux-mmc@xxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/mmc/core/core.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff -puN drivers/mmc/core/core.c~mmc-use-regulator-framework-correctly drivers/mmc/core/core.c --- a/drivers/mmc/core/core.c~mmc-use-regulator-framework-correctly +++ a/drivers/mmc/core/core.c @@ -784,11 +784,6 @@ int mmc_regulator_set_ocr(struct regulat { int result = 0; int min_uV, max_uV; - int enabled; - - enabled = regulator_is_enabled(supply); - if (enabled < 0) - return enabled; if (vdd_bit) { int tmp; @@ -819,9 +814,9 @@ int mmc_regulator_set_ocr(struct regulat else result = 0; - if (result == 0 && !enabled) + if (result == 0) result = regulator_enable(supply); - } else if (enabled) { + } else { result = regulator_disable(supply); } _ Patches currently in -mm which might be from adrian.hunter@xxxxxxxxx are origin.patch linux-next.patch mmc-recognize-csd-structure.patch mmc-recognize-csd-structure-fix.patch mmc-split-mmc_sd_init_card.patch mmc-implement-sd-combo-iomem-support.patch mmc-omap-fix-for-bus-width-which-improves-sd-cards-peformance.patch sdio-allow-non-standard-sdio-cards.patch omap_hsmmc-add-init_card-pass-through-callback.patch omap-pandora-pass-wl1251-information-to-sdio-core.patch mmc-add-erase-secure-erase-trim-and-secure-trim-operations.patch mmc_block-add-discard-support.patch omap_hsmmc-add-erase-capability.patch block-add-secure-discard.patch mmc_block-add-support-for-secure-discard.patch mmc_test-add-performance-tests.patch mmc_test-fix-large-memory-allocation.patch mmc-use-regulator-framework-correctly.patch -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html