Hi Vitaly, On Mon, Aug 2, 2010 at 7:19 PM, Vitaly Wool <vitalywool@xxxxxxxxx> wrote: > On Mon, Aug 2, 2010 at 5:59 PM, Ohad Ben-Cohen <ohad@xxxxxxxxxx> wrote: >> >> Check out patch no. 9: > > sorry for the confusion. However, I guess if the platform doesn't > supply this value, we'll just consider it 0? Without any warning, > right? > > The problem is, we can't really distinguish between this field not set > and value zero, and that means something is wrong with the design. The > easiest way is probably changing the clock ids to start with 1. I don't think it's a huge deal as adding new devices on board files is anyway something that is done carefully and not so often. Btw, we have this kind of mechanism in other locations of the kernel as well and it doesn't seem to be problematic (e.g. spi->chip_select, spi->mode, spi->irq, ...). Having said that I don't mind applying your proposal either and pushing those defines by 1 in the driver. Luca what do you think ? Thanks, Ohad. > > Thanks, > Vitaly > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
