> -----Original Message----- > From: Adrian Hunter [mailto:adrian.hunter@xxxxxxxxx] > Sent: Tuesday, July 27, 2010 6:52 PM > To: Ghorai, Sukumar > Cc: linux-mmc@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH] mmc: failure of block read wait for long time > > Sukumar Ghorai wrote: > > multi-block read failure retries in single block read one by one. It > continues > > retry of subsequent blocks, even after failure. Application will not be > able > > to decode the interleave data (even if few single block read success). > > This patch fixes this problem by returning at the first failure instead > of > > waiting for long duration. > > How can you know what sectors are important to the upper layers? [Ghorai] 1. This is obvious either give the complete data to above layer or not. And every protocol follows that. 2. And other scenario, say apps request for to read the 128MB data and it will take quite long time before returning in failure case. 3. it is quite obvious if the read fail for sector(x) it will fail for sector(x+1) > > > > > Signed-off-by: Sukumar Ghorai <s-ghorai@xxxxxx> > > --- > > drivers/mmc/card/block.c | 1 - > > 1 files changed, 0 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c > > index cb9fbc8..cfb0827 100644 > > --- a/drivers/mmc/card/block.c > > +++ b/drivers/mmc/card/block.c > > @@ -419,7 +419,6 @@ static int mmc_blk_issue_rq(struct mmc_queue *mq, > struct request *req) > > spin_lock_irq(&md->lock); > > ret = __blk_end_request(req, -EIO, > brq.data.blksz); > > spin_unlock_irq(&md->lock); > > - continue; > > } > > goto cmd_err; > > } > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > > the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Regards, Ghorai -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
