On Wed, 07 Jul 2010 10:59:52 +0900 Yusuke Goda <yusuke.goda.sx@xxxxxxxxxxx> wrote: > This patch clears only necessary bit. > > Signed-off-by: Yusuke Goda <yusuke.goda.sx@xxxxxxxxxxx> > --- > drivers/mmc/host/tmio_mmc.h | 5 +---- > 1 files changed, 1 insertions(+), 4 deletions(-) > > diff --git a/drivers/mmc/host/tmio_mmc.h b/drivers/mmc/host/tmio_mmc.h > index 64f7d5d..7944604 100644 > --- a/drivers/mmc/host/tmio_mmc.h > +++ b/drivers/mmc/host/tmio_mmc.h > @@ -82,10 +82,7 @@ > > #define ack_mmc_irqs(host, i) \ > do { \ > - u32 mask;\ > - mask = sd_ctrl_read32((host), CTL_STATUS); \ > - mask &= ~((i) & TMIO_MASK_IRQ); \ > - sd_ctrl_write32((host), CTL_STATUS, mask); \ > + sd_ctrl_write32((host), CTL_STATUS, ~(i)); \ > } while (0) Can we have a better changelog please? What was wrong with the old code? How does the patch fix it? What are the user-visible runtime effects of the bug? (It looks like that was a pretty gross bug - how did it pass testing??) -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html