Re: [PATCH v4 4/5] OMAP HSMMC: Adding a flag to determine the card detect type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* kishore kadiyala <kishore.kadiyala@xxxxxx> [100515 11:16]:
> Adding a flag to determine the card detect type which can be
> either GPIO or NON-GPIO.MMC1 Controller of OMAP4 have NON-GPIO
> interrupt line from twl6030 for card detect.
> 
> Signed-off-by: Kishore Kadiyala <kishore.kadiyala@xxxxxx>
> ---
>  arch/arm/mach-omap2/board-2430sdp.c          |    2 ++
>  arch/arm/mach-omap2/board-3430sdp.c          |    3 +++
>  arch/arm/mach-omap2/board-cm-t35.c           |    3 +++
>  arch/arm/mach-omap2/board-devkit8000.c       |    2 ++
>  arch/arm/mach-omap2/board-igep0020.c         |    3 +++
>  arch/arm/mach-omap2/board-ldp.c              |    2 ++
>  arch/arm/mach-omap2/board-omap3beagle.c      |    2 ++
>  arch/arm/mach-omap2/board-omap3evm.c         |    2 ++
>  arch/arm/mach-omap2/board-omap3pandora.c     |    4 ++++
>  arch/arm/mach-omap2/board-omap3touchbook.c   |    2 ++
>  arch/arm/mach-omap2/board-overo.c            |    3 +++
>  arch/arm/mach-omap2/board-rx51-peripherals.c |    3 +++
>  arch/arm/mach-omap2/board-zoom-peripherals.c |    3 +++
>  arch/arm/mach-omap2/hsmmc.h                  |    1 +
>  arch/arm/plat-omap/include/plat/mmc.h        |    4 ++++
>  15 files changed, 39 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/board-2430sdp.c b/arch/arm/mach-omap2/board-2430sdp.c
> index a11a575..c7dec0e 100644
> --- a/arch/arm/mach-omap2/board-2430sdp.c
> +++ b/arch/arm/mach-omap2/board-2430sdp.c
> @@ -37,6 +37,7 @@
>  #include <plat/gpmc.h>
>  #include <plat/usb.h>
>  #include <plat/gpmc-smc91x.h>
> +#include <plat/mmc.h>
> 
>  #include "hsmmc.h"
> 
> @@ -196,6 +197,7 @@ static struct omap2_hsmmc_info mmc[] __initdata = {
>  		.mmc		= 1,
>  		.wires		= 4,
>  		.gpio_cd	= -EINVAL,
> +		.cd_type	= GPIO,
>  		.gpio_wp	= -EINVAL,
>  		.ext_clock	= 1,
>  	},

To me it seems it would be simpler to just set a flag for the non-gpio
boards instead of patching all of them for gpio. Also, let's see
what we can do with the generic features flag we have now.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux