On Thu, Apr 22, 2010 at 12:17 AM, Tony Lindgren <tony@xxxxxxxxxxx> wrote: > * kishore kadiyala <kishore.kadiyala@xxxxxx> [100421 11:15]: >> This patch adds MMC1 and MMC2 Controller support for OMAP4430 Board >> file. >> >> Signed-off-by: Kishore Kadiyala <kishore.kadiyala@xxxxxx> >> --- >> arch/arm/mach-omap2/Makefile | 3 +- >> arch/arm/mach-omap2/board-4430sdp.c | 39 +++++++++++++++++++++++++++------- >> 2 files changed, 33 insertions(+), 9 deletions(-) >> >> diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile >> index 4b9fc57..40b291a 100644 >> --- a/arch/arm/mach-omap2/Makefile >> +++ b/arch/arm/mach-omap2/Makefile >> @@ -140,7 +140,8 @@ obj-$(CONFIG_MACH_IGEP0020) += board-igep0020.o \ >> hsmmc.o >> obj-$(CONFIG_MACH_OMAP3_TOUCHBOOK) += board-omap3touchbook.o \ >> hsmmc.o >> -obj-$(CONFIG_MACH_OMAP_4430SDP) += board-4430sdp.o >> +obj-$(CONFIG_MACH_OMAP_4430SDP) += board-4430sdp.o \ >> + hsmmc.o >> >> obj-$(CONFIG_MACH_OMAP3517EVM) += board-am3517evm.o >> >> diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-omap2/board-4430sdp.c >> index 32cbd72..eae7c80 100644 >> --- a/arch/arm/mach-omap2/board-4430sdp.c >> +++ b/arch/arm/mach-omap2/board-4430sdp.c >> @@ -33,6 +33,7 @@ >> #include <plat/usb.h> >> #include <asm/hardware/gic.h> >> #include <asm/hardware/cache-l2x0.h> >> +#include "hsmmc.h" >> >> static struct platform_device sdp4430_lcd_device = { >> .name = "sdp4430_lcd", >> @@ -80,17 +81,27 @@ static int __init omap_l2_cache_init(void) >> early_initcall(omap_l2_cache_init); >> #endif >> >> - >> -static struct regulator_consumer_supply sdp4430_vmmc_supply[] = { >> - { >> - .supply = "vmmc", >> - }, >> +static struct omap2_hsmmc_info mmc[] = { >> { >> - .supply = "vmmc", >> + .mmc = 1, >> + .wires = 8, >> + /* "mmc0_cd" is not a gpio interrupt >> + * but is a phoenix interrupt >> + */ >> + .gpio_cd = 384, > > You can't use hardcoded irq numbers for twl interrupts. They can change. > See sdp3430_twl_gpio_setup() for example. I am working on it and will avoid hard coding . Regards, Kishore -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html