Re: + sdhci-rename-sdhci-i-o-accessor-functions.patch added to -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 30 Apr 2010 07:38:17 +0100
Matt Fleming <matt@xxxxxxxxxxxxxxxxx> wrote:

> On Thu, 29 Apr 2010 15:29:26 -0700, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> > Subject: sdhci: build fix: rename SDHCI I/O accessor functions
> > From: Matt Fleming <matt@xxxxxxxxxxxxxxxxx>
> > 
> > Unfortunately some architectures #define their read{b,w,l} and
> > write{b,w,l} I/O accessors which makes the SDHCI I/O accessor functions of
> > the same names subject to preprocessing.  This leads to the following
> > compiler error,
> > 
> > In file included from drivers/mmc/host/sdhci.c:26:
> > drivers/mmc/host/sdhci.h:318:35: error: macro "writel" passed 3 arguments, but takes just 2
> > 
> > Rename the SDHCI I/O functions so that CONFIG_MMC_SDHCI_IO_ACCESSORS can
> > be enabled for architectures that implement their read{b,w,l} and
> > write{b,w,l} functions with macros.
> > 
> > Signed-off-by: Matt Fleming <matt@xxxxxxxxxxxxxxxxx>
> > Cc: Zhangfei Gao <zgao6@xxxxxxxxxxx>
> > Acked-by: Anton Vorontsov <cbouatmailru@xxxxxxxxx>
> > Cc: <linux-mmc@xxxxxxxxxxxxxxx>
> > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> 
> Hi Andrew,
> 
> this patch got a couple more ACKs from Wolfram Sang and Ben Dooks. Would
> like me to respin the patch?

I updated the changelog text, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux