Hi Ian On Wed, 21 Apr 2010, Guennadi Liakhovetski wrote: > This patch series adds DMA support to the tmio_mmc SD/MMC host driver, > using the dmaengine API. So far this is only used on SuperH platforms, > will also be supported on ARM shmobile boards, both use the sh_mobile_sdhi > MFD driver. Other TMIO MFD implementations are unaffected. The patch > transparently falls back to PIO if no DMA is configured by the MFD driver, > or if DMA initialisation or execution fail. Do you think you'd be able to comment on this patch-series? Maybe you could give your initial opinion about the way I chose to integrate DMA into tmio_mmc.c: do you agree with it? Or would you prefer it to depend on a config-option? Maybe put it in a separate tmio_dma.c file? I'd then submit a v2 of the series, which you could then review in detail. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html