On Wed, 21 Apr 2010, Magnus Damm wrote:
> Hi Guennadi,
>
> On Wed, Apr 21, 2010 at 11:36 AM, Guennadi Liakhovetski
> <g.liakhovetski@xxxxxx> wrote:
> > SuperH SDHI controllers can use DMA, add slave IDs to the header and slave
> > definitions to sh7722.
> >
> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>
> > ---
> > arch/sh/include/asm/dmaengine.h | 4 ++++
> > arch/sh/kernel/cpu/sh4a/setup-sh7722.c | 10 ++++++++++
> > 2 files changed, 14 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/sh/include/asm/dmaengine.h b/arch/sh/include/asm/dmaengine.h
> > index 2a02b61..876e601 100644
> > --- a/arch/sh/include/asm/dmaengine.h
> > +++ b/arch/sh/include/asm/dmaengine.h
> > @@ -29,6 +29,10 @@ enum {
> > SHDMA_SLAVE_SIUA_RX,
> > SHDMA_SLAVE_SIUB_TX,
> > SHDMA_SLAVE_SIUB_RX,
> > + SHDMA_SLAVE_SDHI0_RX,
> > + SHDMA_SLAVE_SDHI0_TX,
> > + SHDMA_SLAVE_SDHI1_RX,
> > + SHDMA_SLAVE_SDHI1_TX,
> > };
> >
> > #endif
>
> Thanks for your work on this. Two SDHIs may be enough for most
> processor types, but I think the G3 processor actually has three. With
> that in mind, I think it makes more sense to keep the slave ids
> together with the processor specific bits in for instance
> arch/sh/include/cpu-sh4/cpu/sh7722.h.
>
> If you have time, can you please make a patch that moves the slave ids
> into the processor specific header files? This on top of the other
> code in the sh/dmaengine topic branch.
Ok, yes, first, I forgot to mention - this patch series is based on your
earlier SH dmaengine patches. Secondly - sure, we can move these defines
in cpu-specific headers, otoh - why? This is just an enum, it doesn't take
space in binaries, and having them all together helps uniformity and
avoids duplication, I think. So, I would just add those SDHI2 macros to
this list. The important thing is, the actual slave definition array are
per-CPU. Which is now the case after your patch series.
> With that in place it will be easy to extend each processor type by
> itself without having to tie in dependencies on a single asm file.
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
