On Wed, Mar 31, 2010 at 02:38:56PM +0200, Sascha Hauer wrote:
> On Tue, Mar 30, 2010 at 08:31:59PM +0200, Daniel Mack wrote:
> > + dev_err(mmc_dev(host->mmc),
> > + "%s: read -ETIMEDOUT\n", __func__);
> > data->error = -ETIMEDOUT;
> > } else {
> > + dev_err(mmc_dev(host->mmc), "%s: -EIO\n", __func__);
>
> Do we really want to have these messages with dev_err? In the subject
> you are talking about debug output.
This _is_ definitely an error if get there, so I'll rather change the
commit message ;)
>
> > data->error = -EIO;
> > }
> > - } else {
> > + } else
> > data->bytes_xfered = host->datasize;
> > - }
>
> Documentation/CodingStyle says that if braces are used in one branch of
> a conditional then they should be used in both branches.
> I personally don't care much about this statement but I think we should
> leave it as is. Otherwise some day someone wants to change it back
> according to the coding style.
Ok, true. I'll fix this (and the commit message) and resend.
Thanks,
Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
