Re: [PATCH 01/03] omap hsmmc: prevent race between dma and hsmmc callback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Venkatraman S <svenkatr@xxxxxx> writes:

> Shilimkar, Santosh wrote:
>>> -----Original Message-----
>>> From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap-owner@xxxxxxxxxxxxxxx] On Behalf Of
>>> Venkatraman S
>>> Sent: Wednesday, March 10, 2010 7:42 PM
>>> To: linux-omap@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-mmc@xxxxxxxxxxxxxxx
>>> Cc: Adrian Hunter; Chikkature Rajashekar, Madhusudhan; Tony Lindgren
>>> Subject: [PATCH 01/03] omap hsmmc: prevent race between dma and hsmmc callback
>>>
>>> See previous post http://patchwork.kernel.org/patch/82907/
>>> Rebased to 2.6.34-rc1 and fixed comment alignment.
>>>
>> Why did you dropped change log in all your patches? You should retain that and
>> just change the patch version in the subject.
>>
>
> My bad. I just edited the merge commit to point to the previous
> threads and posted it.
> Should I post them again ?
>

Yes.  

As Santosh pointed out, keep the changelog. and add any comments about
how this differs from previous versions after the '---' in the
changelog.

Keep in mind that the changelog will be stored in the git history and
should be useful without having to reference previous versions etc.

Anything useful to the reviewers but not important for the changelog
should go after the '---' since that will be ignored by git when
applying.

Kevin

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux