Hi Andrew, On Wed, Mar 10, 2010 at 1:38 AM, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > On Wed, 24 Feb 2010 12:35:47 -0800 > Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: > >> On Tue, 26 Jan 2010 14:40:04 +0300 Vladimir Zapolskiy <vzapolskiy@xxxxxxxxx> wrote: >> >> > Signed-off-by: Vladimir Zapolskiy <vzapolskiy@xxxxxxxxx> >> > Cc: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> >> > Cc: Pierre Ossman <pierre@xxxxxxxxx> >> > --- >> > drivers/mmc/host/mxcmmc.c | 2 +- >> > 1 files changed, 1 insertions(+), 1 deletions(-) >> > >> > diff --git a/drivers/mmc/host/mxcmmc.c b/drivers/mmc/host/mxcmmc.c >> > index 60a2b69..faa7b76 100644 >> > --- a/drivers/mmc/host/mxcmmc.c >> > +++ b/drivers/mmc/host/mxcmmc.c >> > @@ -708,7 +708,7 @@ static int mxcmci_probe(struct platform_device *pdev) >> > mmc->max_blk_size = 2048; >> > mmc->max_blk_count = 65535; >> > mmc->max_req_size = mmc->max_blk_size * mmc->max_blk_count; >> > - mmc->max_seg_size = mmc->max_seg_size; >> > + mmc->max_seg_size = mmc->max_req_size; >> > >> > host = mmc_priv(mmc); >> > host->base = ioremap(r->start, resource_size(r)); >> >> Please don't send unchangelogged patches. >> >> I am not able to determine the user-visible impact of this bug hence I >> am not able to determine which kernel(s) we should merge this patch >> into. >> > > This patch is still stuck due to lack of any changelog explanation of > what it does. Vladimir seems to have vanished. Can someone please > take a look? Review the patch and explain what it does? > >From my view this unpleasant typo appeared while porting the driver from Freescale original sources, where anyone can easily find the correct version. Current incorrect version potentially can influence segment and merge handling in block subsystem via MMC request queue settings. > Obviously the old code was wrong. But is the new code right, and what > runtime effects does it have? > > > > Thanks. > > > From: Vladimir Zapolskiy <vzapolskiy@xxxxxxxxx> > > -ENOCHANGELOG > > Signed-off-by: Vladimir Zapolskiy <vzapolskiy@xxxxxxxxx> > Cc: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > Cc: Pierre Ossman <pierre@xxxxxxxxx> > Cc: <linux-mmc@xxxxxxxxxxxxxxx> > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > --- > > drivers/mmc/host/mxcmmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -puN drivers/mmc/host/mxcmmc.c~mxcmmc-fixed-max_seg_size-value-on-initialization drivers/mmc/host/mxcmmc.c > --- a/drivers/mmc/host/mxcmmc.c~mxcmmc-fixed-max_seg_size-value-on-initialization > +++ a/drivers/mmc/host/mxcmmc.c > @@ -708,7 +708,7 @@ static int mxcmci_probe(struct platform_ > mmc->max_blk_size = 2048; > mmc->max_blk_count = 65535; > mmc->max_req_size = mmc->max_blk_size * mmc->max_blk_count; > - mmc->max_seg_size = mmc->max_seg_size; > + mmc->max_seg_size = mmc->max_req_size; > > host = mmc_priv(mmc); > host->base = ioremap(r->start, resource_size(r)); > _ > > Regards, Vladimir -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
