On Sun, Feb 21, 2010 at 03:15:15PM +0100, Wolfram Sang wrote: > > > Checking ./drivers/mmc/card/queue.c... > > > [./drivers/mmc/card/queue.c:212]: (style) Redundant condition. It is safe to deallocate a NULL pointer > > > [./drivers/mmc/card/queue.c:215]: (style) Redundant condition. It is safe to deallocate a NULL pointer > > > [./drivers/mmc/card/queue.c:208]: (style) Redundant condition. It is safe to deallocate a NULL pointer > > > [./drivers/mmc/card/queue.c:239]: (style) Redundant condition. It is safe to deallocate a NULL pointer > > > [./drivers/mmc/card/queue.c:246]: (style) Redundant condition. It is safe to deallocate a NULL pointer > > > > This report appears to be using a kernel config with CONFIG_MMC_BLOCK_BOUNCE=y. > > What does cppcheck report for the CONFIG_MMC_BLOCK_BOUNCE=n case? I believe > > you will find that it is not sage to remove those conditions for the > > CONFIG_MMC_BLOCK_BOUNCE=n case. > > > > How is that? kfree(NULL) is legal. Right, in which case, please disregard. : ) Thanks! -- Regards, George > > -- > Pengutronix e.K. | Wolfram Sang | > Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
