Re: [PATCH] sdhci: add adma descriptor set call

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 28 Jan 2010 05:29:56 +0000
Ben Dooks <ben-linux@xxxxxxxxx> wrote:

> The code to write the ADMA descriptor into memory is repeated several
> times throughout sdhci_adma_table_pre, and thus should be moved into a
> common function. This will also be useful if the patch to make the write
> more efficient is accepted.
> 
> ...
>
> @@ -499,15 +496,9 @@ static int sdhci_adma_table_pre(struct sdhci_host *host,
>  		/*
>  		* Add a terminating entry.
>  		*/
> -		desc[7] = 0;
> -		desc[6] = 0;
> -		desc[5] = 0;
> -		desc[4] = 0;
> -
> -		desc[3] = 0;
> -		desc[2] = 0;
> -		desc[1] = 0x00;
> -		desc[0] = 0x03; /* nop, end, valid */
> +
> +		/* nop, end, valid */
> +		sdhci_set_adma_desc(desc, 0, 0, 0x3);
>  	}

What kernel are you patching?  Current mainline is different from the above.
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux