On Mon, Dec 14, 2009 at 08:33:25PM +0100, Albert Herranz wrote: > This patch breaks down sdhci-of into a core portion and a eSDHC portion, > clearing the path to easily support additional hardware using the same > OF driver. > > Signed-off-by: Albert Herranz <albert_herranz@xxxxxxxx> Looks really good, thanks a lot for your work! Few minor nits down below. [...] > +++ b/drivers/mmc/host/sdhci-of-core.c Not sure if adding -core prefix makes things better (it actually makes the patch harder to review). Can we leave the core in sdhci-of.c, and just factor out esdhc stuff from it? [...] > +#include <linux/mmc/host.h> > +#include <asm/machdep.h> > +#include "sdhci-of.h" > + You still need to include sdhci.h. Files need to include all the headers they need. I.e., here you should not rely on the fact that sdhci-of.h includes sdhci.h. [...] > --- /dev/null > +++ b/drivers/mmc/host/sdhci-of.h > @@ -0,0 +1,42 @@ [...] > +extern struct sdhci_of_data sdhci_esdhc; > + > +#endif /* __SDHCI_OF_H */ > + > -- > 1.6.3.3 Unneeded empty line at the end of sdhci-of.h. If you'll manage to resend the patches before Linus roll the -rc1 out, I'd be glad to beg Andrew to send this for v2.6.33. Because it will be a pity if it has to wait for 2.6.34. -- Anton Vorontsov email: cbouatmailru@xxxxxxxxx irc://irc.freenode.net/bd2 -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
