On Mon, Nov 09, 2009 at 02:27:49PM -0800, Andrew Morton wrote: > On Sun, 1 Nov 2009 12:59:05 +0100 > Ladislav.Michl@xxxxxxxxx wrote: > > > Free IRQ on remove. > > > > Signed-off-by: Ladislav Michl <ladis@xxxxxxxxxxxxxx> > > Acked-by: Tony Lindgren <tony@xxxxxxxxxxx> > > > > diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c > > index 5d773b8..5f970e2 100644 > > --- a/drivers/mmc/host/omap.c > > +++ b/drivers/mmc/host/omap.c > > @@ -1529,6 +1529,7 @@ static int mmc_omap_remove(struct platform_device *pdev) > > host->pdata->cleanup(&pdev->dev); > > > > mmc_omap_fclk_enable(host, 0); > > + free_irq(host->irq, host); > > clk_put(host->fclk); > > clk_disable(host->iclk); > > clk_put(host->iclk); > > This is a poor changelog. I'm sorry for that as well as for sending this patch twice. I will do better next time. > The reader doesn't know what the implication of the bug is. I _assume_ > that it means that the driver can only be loaded a single time. That > on a second modprobe, it fails to allocate the interrupt and fails. This is perfectly correct assumption. > In which case this is a fairly serious bug and perhaps the patch should > be backported into the -stable tree. There is no point backporting it as this driver is broken for ages without single complain. (details here: http://article.gmane.org/gmane.linux.kernel.mmc/649) > Or I could be all wrong about all of that. This is why it's better if > the patch submitter *explains* these things, rather than leaving others > to guess. Best regards, ladis -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
