On Wed, 11 Nov 2009 04:44:36 +0000 Ben Hutchings <ben@xxxxxxxxxxxxxxx> wrote: > Some people run general-purpose distribution kernels on netbooks with > a card that is physically non-removable or logically non-removable > (e.g. used for /home) and cannot be cleanly unmounted during suspend. > Add a module parameter to set whether cards are assumed removable or > non-removable, with the default set by CONFIG_MMC_UNSAFE_RESUME. > The description really doesn't give me enough info to work out what's happening here and why this is being proposed. But it smells nasty. > index ab37a6d..bb22ffd 100644 > --- a/drivers/mmc/core/Kconfig > +++ b/drivers/mmc/core/Kconfig > @@ -3,7 +3,7 @@ > # > > config MMC_UNSAFE_RESUME > - bool "Allow unsafe resume (DANGEROUS)" > + bool "Assume MMC/SD cards are non-removable (DANGEROUS)" > help > If you say Y here, the MMC layer will assume that all cards > stayed in their respective slots during the suspend. The > @@ -14,3 +14,5 @@ config MMC_UNSAFE_RESUME > This option is usually just for embedded systems which use > a MMC/SD card for rootfs. Most people should say N here. > > + This option sets a default which can be overridden by the > + module parameter "removable=0" or "removable=1". > diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c > index d98b0e2..010c964 100644 > --- a/drivers/mmc/core/core.c > +++ b/drivers/mmc/core/core.c > @@ -48,6 +48,22 @@ int use_spi_crc = 1; > module_param(use_spi_crc, bool, 0); > > /* > + * We normally treat cards as removed during suspend if they are not > + * known to be on a non-removable bus, to avoid the risk of writing > + * back data to a different card after resume. Allow this to be > + * overridden if necessary. > + */ So we have a module parameter which nobody knows about. If they don't set this parameter which they don't know about, the kernel will trash their filesystem?? > +#ifdef CONFIG_MMC_UNSAFE_RESUME > +int mmc_assume_removable; > +#else > +int mmc_assume_removable = 1; > +#endif > +module_param_named(removable, mmc_assume_removable, bool, 0644); > +MODULE_PARM_DESC( > + removable, > + "MMC/SD cards are removable and may be removed during suspend"); > + -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
