Thadeu Lima de Souza Cascardo wrote:
> --- a/drivers/mmc/card/sdio_uart.c
> +++ b/drivers/mmc/card/sdio_uart.c
[...]
> @@ -946,31 +948,31 @@ static int sdio_uart_proc_show(struct seq_file *m, void *v)
> seq_printf(m, "%d: uart:SDIO", i);
> if(capable(CAP_SYS_ADMIN)) {
> seq_printf(m, " tx:%d rx:%d",
> - port->icount.tx, port->icount.rx);
> + port->icount.tx, port->icount.rx);
> if (port->icount.frame)
> seq_printf(m, " fe:%d",
> - port->icount.frame);
> + port->icount.frame);
> if (port->icount.parity)
> seq_printf(m, " pe:%d",
> - port->icount.parity);
> + port->icount.parity);
> if (port->icount.brk)
> seq_printf(m, " brk:%d",
> - port->icount.brk);
> + port->icount.brk);
> if (port->icount.overrun)
> seq_printf(m, " oe:%d",
> - port->icount.overrun);
> + port->icount.overrun);
> if (port->icount.cts)
[...]
The style problem of the original code was not indentation, but depth of
indentation levels. Why not factor this cascade out to a
show_icount_fields() function?
Plus, I hope Jiri enhanced your changelog a bit before he committed it.
(I only looked at this patch because I was wondering what subsystem it
changed --- the patch title doesn't say it.)
--
Stefan Richter
-=====-==--= =-=- =----
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
