Re: [PATCH 1/4] [MMC] core SDIO suspend/resume support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 02 Sep 2009 14:37:23 -0400
Nicolas Pitre <nico@xxxxxxx> wrote:

> 
> When resuming, we make sure the same card is still inserted by comparing
> the vendor and product IDs.  If there is a mismatch, or if there is simply
> no card anymore in the slot, then the previous card is "removed" and the
> new card is detected.
> 

I know this is an area with a lot of differing views, but I see this as
totally insufficient. Like storage cards, this card might have a
non-volatile state that drivers and upper layers rely on being the same
before and after suspend.

(Then there's also the issue of e.g. having two "identical" wifi cards
but with different MAC addresses).

I think the right way to go is to retain enough power to the card for
it to stay initialised and then poke it at resume to see if it is still
running in the same state we left it.

Rgds
-- 
     -- Pierre Ossman

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux