Re: [PATCH 3/4] mm: stop __munlock_pagevec_fill() if THP enounted

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 28, 2015 at 03:22:35PM -0800, Andrew Morton wrote:
> On Thu, 24 Dec 2015 14:51:22 +0300 "Kirill A. Shutemov" <kirill.shutemov@xxxxxxxxxxxxxxx> wrote:
> 
> > THP is properly handled in munlock_vma_pages_range().
> > 
> > It fixes crashes like this:
> >  http://lkml.kernel.org/r/565C5C38.3040705@xxxxxxxxxx
> > 
> > ...
> >
> > --- a/mm/mlock.c
> > +++ b/mm/mlock.c
> > @@ -393,6 +393,13 @@ static unsigned long __munlock_pagevec_fill(struct pagevec *pvec,
> >  		if (!page || page_zone_id(page) != zoneid)
> >  			break;
> >  
> > +		/*
> > +		 * Do not use pagevec for PTE-mapped THP,
> > +		 * munlock_vma_pages_range() will handle them.
> > +		 */
> > +		if (PageTransCompound(page))
> > +			break;
> > +
> >  		get_page(page);
> >  		/*
> >  		 * Increase the address that will be returned *before* the
> 
> I'm trying to work out approximately which patch this patch fixes, and
> it ain't easy.  Help?

"thp: allow mlocked THP again", I think.

-- 
 Kirill A. Shutemov

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]