On 12/25/2015 5:05 PM, Joe Perches wrote:
On Fri, 2015-12-25 at 15:09 -0700, Toshi Kani wrote:
Use of walk_iomem_res() is deprecated in new code. Change
checkpatch.pl to check new use of walk_iomem_res() and suggest
to use walk_iomem_res_desc() instead.
[]
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
@@ -3424,6 +3424,12 @@ sub process {
}
}
+# check for uses of walk_iomem_res()
+ if ($line =~ /\bwalk_iomem_res\(/) {
+ WARN("walk_iomem_res",
+ "Use of walk_iomem_res is deprecated, please use walk_iomem_res_desc instead\n" . $herecurr)
+ }
+
# check for new typedefs, only function parameters and sparse annotations
# make sense.
if ($line =~ /\btypedef\s/ &&
There are 6 uses of this function in the entire kernel tree.
Why not just change them, remove the function and avoid this?
Sorry, I should have put some background in the description. We have
discussed if we can remove walk_iomem_res() in the thread below.
https://lkml.org/lkml/2015/12/23/248
But this may depend on how we deal with the last remaining caller,
walk_iomem_res() with "GART", being discussed in the thread below. I
will update according to the outcome.
https://lkml.org/lkml/2015/12/26/144
Thanks,
-Toshi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>